Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do many archival_tag not have an id_code? #182

Closed
peterdesmet opened this issue Sep 28, 2021 · 5 comments
Closed

Why do many archival_tag not have an id_code? #182

peterdesmet opened this issue Sep 28, 2021 · 5 comments
Assignees
Labels
database Related to ETN database question Further information is requested
Milestone

Comments

@peterdesmet
Copy link
Member

No description provided.

@peterdesmet peterdesmet added the question Further information is requested label Sep 28, 2021
@peterdesmet peterdesmet added this to the 0.2.0 milestone Sep 28, 2021
@jreubens
Copy link
Collaborator

jreubens commented Oct 1, 2021

If I'm correct archival tags never have an id_code, but only a serial. no distinction is made between both in archival tags

@PieterjanVerhelst
Copy link
Collaborator

Indeed, they don't send out an ID that can be picked up by a beacon. So there is only a serial number of the product, the archival tag.

@peterdesmet
Copy link
Member Author

The archival.tags table does have an id_code field however and when populated, it is different from the serial number:

Screenshot 2021-10-04 at 10 29 09

If that field does not make sense, it should be removed. It was confusing to me, because I implemented it as a parameter for get_archival_tags(archival_tag_id = "") (cf. get_acoustic_tags(acoustic_tag_id = ""))

@peterdesmet
Copy link
Member Author

The field should stay, as it is used for acoustic archival tags. Model should likely be changed though, see #192. Moving issue to new milestone.

@peterdesmet peterdesmet modified the milestones: 2.0.0, New tag model Oct 5, 2021
@peterdesmet
Copy link
Member Author

There is not action item in this issue, closing.

@peterdesmet peterdesmet added database Related to ETN database and removed update DB labels Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Related to ETN database question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants