-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add typestack component (resolves #16) #19
Conversation
✅ Deploy Preview for idg-ds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we'll want to split these into components for:
Header Level 1
Header Level 2
Header Level 3
Header Level 3 (Card)
Header Level 4
Paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the link styles from this? I would like to have a separate PR for that with the hover, focus and active states as well.
Hey @greatislander I noticed that the classes used for height and width of color component is removed from your badge work, so the color page is broken. None of the space variables seems to give as big width and height as it was before, so should I create a custom class for bigger width and height using existing spacing variables? like calc(4*--space-something) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two final changes, @chosww — thanks!
Thanks for your review and feedback :) |
See #16 for details.