Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typestack component (resolves #16) #19

Merged
merged 17 commits into from
Jul 20, 2023

Conversation

chosww
Copy link
Collaborator

@chosww chosww commented Jul 19, 2023

See #16 for details.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for idg-ds ready!

Name Link
🔨 Latest commit c41e97b
🔍 Latest deploy log https://app.netlify.com/sites/idg-ds/deploys/64b95fd4978c9200086c7304
😎 Deploy Preview https://deploy-preview-19--idg-ds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chosww chosww added the enhancement New feature or request label Jul 19, 2023
@chosww chosww linked an issue Jul 19, 2023 that may be closed by this pull request
@chosww chosww requested a review from greatislander July 19, 2023 15:45
@chosww chosww added this to the 1.0.0 milestone Jul 19, 2023
@chosww chosww self-assigned this Jul 19, 2023
@greatislander greatislander enabled auto-merge (squash) July 19, 2023 17:09
Copy link
Member

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we'll want to split these into components for:

Header Level 1
Header Level 2
Header Level 3
Header Level 3 (Card)
Header Level 4
Paragraph

src/_includes/layout.njk Outdated Show resolved Hide resolved
Copy link
Member

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the link styles from this? I would like to have a separate PR for that with the hover, focus and active states as well.

@chosww
Copy link
Collaborator Author

chosww commented Jul 19, 2023

Hey @greatislander I noticed that the classes used for height and width of color component is removed from your badge work, so the color page is broken. None of the space variables seems to give as big width and height as it was before, so should I create a custom class for bigger width and height using existing spacing variables? like calc(4*--space-something)

Copy link
Member

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two final changes, @chosww — thanks!

src/_includes/components/typography/typography.config.js Outdated Show resolved Hide resolved
src/static/css/utilities.css Outdated Show resolved Hide resolved
@chosww
Copy link
Collaborator Author

chosww commented Jul 20, 2023

Two final changes, @chosww — thanks!

Thanks for your review and feedback :)

@greatislander greatislander merged commit 68c4bc6 into inclusive-design:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: type stack
2 participants