Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor persistence_test and move API call retry to API Service #437

Open
lwolczynski opened this issue Sep 30, 2024 · 0 comments · Fixed by #491
Open

Refactor persistence_test and move API call retry to API Service #437

lwolczynski opened this issue Sep 30, 2024 · 0 comments · Fixed by #491

Comments

@lwolczynski
Copy link
Contributor

Under certain circumstances (starting a continuedAsNew workflow is one of them) it might take time before Temporal/Candace API calls can be resolved successfully and expected data is returned. We should refactor the code and retry API calls when a certain response is received (for example: 500 response)

ACs:

  • Retry API calls when certain responses are received
    • TODO: Need to decide on checking error types, and backoff strategy
  • Refactor persistence_test.go so it does not need to use Sleep.time method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant