Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form fields and integration tests #32

Closed
gangster opened this issue Aug 3, 2014 · 5 comments
Closed

Form fields and integration tests #32

gangster opened this issue Aug 3, 2014 · 5 comments

Comments

@gangster
Copy link

gangster commented Aug 3, 2014

Hi there. I've been using ember-forms in my project and it's been working out great so far. Thanks to all the contributors to the project.

Is it possible to add custom classes to the input fields or the wrappers? The use case I have in mind is writing integration tests. Not seeing how to get a handle on the form field without being able to reference it by a known selector.

Thanks again!

@toranb
Copy link

toranb commented Aug 6, 2014

+1 here

I'm doing some integration testing myself and realized I can't set the id of the input (to select during my integration test for example)

any idea how this could be added/ or do you have plans to support this? any reason this isn't already in the library? Thanks for such a great project! keep up the great work!

@williamsbdev
Copy link

I am also having this problem. I attempted to put an id="id_name" on the em-input and it actually puts the id name on the div surrounding the input. How would I be able to put an id on the input instead of the div?

Thanks!

@asaf
Copy link
Contributor

asaf commented Aug 15, 2014

So to summarize:

  • Add a way to add custom classes to input fields and wrappers
  • Propagate some property from the top level component as the id of the sub components.

@toranb
Copy link

toranb commented Aug 15, 2014

Sounds good - the big one is allowing me to set an id for the element (so I can find it/ inspect it with ember-testing). The first bullet point (to add classes) would be a nice + 1 / iteration on this story

@asaf asaf closed this as completed in 03481f2 Aug 21, 2014
@asaf
Copy link
Contributor

asaf commented Aug 21, 2014

It's possible to set cid="someId" and it'll be propagated to the input control itself.

Regarding custom classes, I opened an issue for it #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants