Use single quotes for auth test html attrs #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain why the quotes are causing this issue? |
|
I thought I might have messed up the sanitizing when I did that PR... might switch to using built in WordPress functions as I did elsewhere. |
|
@pfefferle Yes, sorry: the quotes are causing the issue because when this is output it is inside JSON.
the double quote becomes a closing quote for the |
should fix #204, close #201 and fix #188 the quotes were causing the error because this string is output in JSON. the parser interprets the opening quote of the attribute value as the closing quote of the "message" property's value, and rather than throw an error php returns a jolly `null` {"message":"<div class="notice notice-success"><p>Authorization Header ^
|
i've added that info to the commit message:) |
Merged
|
Closed as implemented using esc_html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #204, close #201 and fix #188 and close #158