Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BN included twice by browserify #190

Closed
Ayms opened this issue Sep 2, 2019 · 4 comments
Closed

BN included twice by browserify #190

Ayms opened this issue Sep 2, 2019 · 4 comments

Comments

@Ayms
Copy link

Ayms commented Sep 2, 2019

Continuation of indutny/bn.js#227

And please see browserify/browserify#1923

Let's see if we get some feedback, apparently it does not look like an elliptic issue but I think it would not be bad to add something like utils.BN=BN or in elliptic.js so BN becomes available from elliptic directly

@fanatid
Copy link
Contributor

fanatid commented Sep 2, 2019

Right now you can use such hack for access to bn.js from elliptic:

const elliptic = require('elliptic')
const BN = elliptic.utils.intFromLE('0').constructor

@Ayms
Copy link
Author

Ayms commented Sep 2, 2019

OK, but my suggestion is to make it directly available from elliptic, not a big deal I think

Did you see the posts from (closed) browserify/browserify#1923 ?

Why does bn.js appear twice after npm install of elliptic?

@fanatid
Copy link
Contributor

fanatid commented Sep 2, 2019

Yeah, I had seen. I do not see that bn.js installed twice:

npm install elliptic
+ elliptic@6.5.0
npm ls bn.js
/home/kirill/tmp/node-test
└─┬ elliptic@6.5.0
  └── bn.js@4.11.8

Only one bn.js version. Same for yarn.

@Ayms
Copy link
Author

Ayms commented Sep 2, 2019

Closing... not sure what I did when I installed elliptic first, maybe I used a too old version of npm,reinstalling correctly does not cause the duplication effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants