Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description field become an empty object if upnp port-mapping description is an empty string #35

Open
MelvinTo opened this issue Dec 12, 2017 · 0 comments

Comments

@MelvinTo
Copy link

please check out description below, looks like an xml2js bug?

node-nat-upnp version 1.1.1

i think the xml2js dependency should be updated. xml2js "0.4.19" doesn't have this issue.

> var natUpnp = require('nat-upnp');
undefined
> var client = natUpnp.createClient();
undefined
> client.getMappings(function(err, results) { console.log(results) })
undefined
[ { public: { host: '', port: 13760 },
    private: { host: '192.168.50.48', port: 1080 },
    protocol: 'tcp',
    enabled: true,
    description: {},
    ttl: 0,
    local: false } ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant