Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a mechanism to embed a Windows manifest resource #197

Closed
mharbison72 opened this issue Nov 18, 2019 · 2 comments
Closed

Need a mechanism to embed a Windows manifest resource #197

mharbison72 opened this issue Nov 18, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@mharbison72
Copy link

Mercurial's wrapper exe gets an embedded manifest resource courtesy of setup.py, and that's needed for the Inno installer[1].

[1] https://phab.mercurial-scm.org/D7160

@indygreg indygreg added the enhancement New feature or request label Nov 24, 2019
@indygreg
Copy link
Owner

I think rust-lang/rfcs#721 tracks the Rust feature for this. But since PyOxidizer mostly abstracts away the existence of Rust/Cargo, we should be able to make something work here.

@indygreg
Copy link
Owner

I'm reasonably sure the implementation I just committed works. But I don't have an easy way to verify. If anyone has an old version of Windows sitting around and wants to test, by all means! I could generate an executable to test with if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants