Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "doesn't look like" daemon check as it seems unnecessary #7

Open
spiltcoffee opened this issue Jul 12, 2022 · 0 comments
Open

Remove "doesn't look like" daemon check as it seems unnecessary #7

spiltcoffee opened this issue Jul 12, 2022 · 0 comments

Comments

@spiltcoffee
Copy link

spiltcoffee commented Jul 12, 2022 •
edited
Loading

Related to inetum-orleans/nfs4j-daemon#9.

Suggest removing this code: https://github.com/inetum-orleans/vagrant-nfs4j/blob/develop/lib/vagrant-nfs4j/config/nfs4j.rb#L52-L54

Unsure what it is trying to achieve, as it seems highly unlikely any other .exe is going to respond here? Unless I've grossly misunderstood what daemon_cmd contains, in which case ignore this.
@spiltcoffee spiltcoffee changed the title Remove "doesn't look like" check as it seems unnecessary. Remove "doesn't look like" check as it seems unnecessary Jul 12, 2022
@spiltcoffee spiltcoffee changed the title Remove "doesn't look like" check as it seems unnecessary Remove "doesn't look like" daemon check as it seems unnecessary Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spiltcoffee