Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3: Identify and remove filters #501

Open
MatthewGidcomb opened this issue Jun 2, 2024 · 1 comment
Open

Vue 3: Identify and remove filters #501

MatthewGidcomb opened this issue Jun 2, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@MatthewGidcomb
Copy link
Member

One of the big breaking changes in Vue 3 is the removal of the "filters" feature (details). We mainly used this for formatting dates, using a filter provided by the vue-moment plugin.

Alternatives:

  • Use a computed property to process data for display; this has the benefit of caching the results and should theoretically improve render times (although in practice it's probably not noticeable)
  • Per the docs, it's possible to sort of re-implement it manually using globalProperties, but the usage syntax wouldn't quite be the same.

Marking this as a potential good-first-issue because it should be pretty straightforward to identify and address all of these. I'll try to do a pass later and flag any that may need further thought.

@MatthewGidcomb MatthewGidcomb added the good first issue Good for newcomers label Jun 2, 2024
@MatthewGidcomb MatthewGidcomb self-assigned this Jun 2, 2024
@MatthewGidcomb
Copy link
Member Author

MatthewGidcomb commented Jun 9, 2024

Not as many of these as I thought there were. Quick pass turned up:

  • AdminEventsList (dateFormat and ownerLogo)
  • EventCard (truncate - can we refactor this to use a CSS-based approach instead?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant