Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

It's still using AVA app generated with ignite new MyApp -b ir-next #46

Closed
tomaswitek opened this issue May 19, 2017 · 7 comments
Closed
Labels

Comments

@tomaswitek
Copy link

Hi,
great job you're doing here!
Just wanted to ask, when I run ignite new MyApp -b ir-next I still end up with AVA test setup altough I can see that here in the repo you've already moved to Jest.

I'll end up with this package.json:

{
  "name": "MyApp",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "start": "node node_modules/react-native/local-cli/cli.js start",
    "lint": "standard --verbose | snazzy",
    "lintdiff": "git diff --name-only --cached --relative | grep '\\.js$' | xargs standard | snazzy",
    "fixcode": "standard --fix",
    "clean": "rm -rf $TMPDIR/react-* && watchman watch-del-all && npm cache clean",
    "clean:android": "cd android/ && ./gradlew clean && cd .. && react-native run-android",
    "newclear": "rm -rf $TMPDIR/react-* && watchman watch-del-all && rm -rf ios/build && rm -rf node_modules/ && npm cache clean && npm i",
    "test": "ava",
    "test:watch": "ava --watch",
    "coverage": "nyc ava && nyc report --reporter=html && open coverage/index.html || xdg-open coverage/index.html",
    "android:build": "cd android && ./gradlew assembleRelease",
    "android:install": "cd android && ./gradlew assembleRelease && ./gradlew installRelease",
    "android:hockeyapp": "cd android && ./gradlew assembleRelease && puck -submit=auto app/build/outputs/apk/app-release.apk",
    "android:devices": "$ANDROID_HOME/platform-tools/adb devices",
    "android:logcat": "$ANDROID_HOME/platform-tools/adb logcat *:S ReactNative:V ReactNativeJS:V",
    "android:shake": "$ANDROID_HOME/platform-tools/adb devices | grep '\\t' | awk '{print $1}' | sed 's/\\s//g' | xargs -I {} $ANDROID_HOME/platform-tools/adb -s {} shell input keyevent 82",
    "precommit": "npm run git-hook",
    "prepush": "npm run git-hook",
    "git-hook": "npm run lint -s && npm test -s"
  },
  "dependencies": {
    "apisauce": "^0.10.0",
    "format-json": "^1.0.3",
    "lodash": "^4.17.2",
    "querystringify": "0.0.4",
    "ramda": "^0.23.0",
    "react": "~15.4.1",
    "react-native": "0.42.0",
    "react-native-config": "^0.2.1",
    "react-native-device-info": "^0.10.0",
    "react-native-drawer": "^2.3.0",
    "react-native-i18n": "^1.0.0",
    "react-native-vector-icons": "^4.1.1",
    "react-navigation": "^1.0.0-beta.9",
    "react-redux": "^5.0.2",
    "redux": "^3.6.0",
    "redux-persist": "^4.1.0",
    "redux-saga": "^0.14.3",
    "reduxsauce": "0.4.1",
    "seamless-immutable": "^7.0.1"
  },
  "devDependencies": {
    "ava": "^0.18.2",
    "babel-eslint": "^7.1.1",
    "babel-preset-es2015": "^6.18.0",
    "enzyme": "^2.6.0",
    "husky": "^0.13.1",
    "ignite-dev-screens": "^2.0.0-beta.9",
    "ignite-i18n": "^0.1.1",
    "ignite-ir-next": "^0.0.7",
    "ignite-vector-icons": "^0.2.1",
    "mockery": "^2.0.0",
    "nyc": "^10.1.2",
    "react-addons-test-utils": "^15.3.1",
    "react-dom": "^15.4.0",
    "react-native-mock": "^0.3.1",
    "reactotron-apisauce": "^1.7.0",
    "reactotron-react-native": "^1.7.0",
    "reactotron-redux": "^1.7.0",
    "reactotron-redux-saga": "^1.7.0",
    "snazzy": "^6.0.0",
    "standard": "8.6.0"
  },
  "ava": {
    "files": [
      "Tests/**/*.js",
      "!Tests/Setup.js"
    ],
    "require": [
      "babel-register",
      "babel-polyfill",
      "react-native-mock/mock",
      "./Tests/Setup"
    ],
    "babel": "inherit"
  },
  "standard": {
    "parser": "babel-eslint",
    "globals": [
      "describe",
      "it",
      "fetch",
      "navigator",
      "__DEV__",
      "XMLHttpRequest",
      "FormData",
      "React$Element"
    ]
  },
  "config": {
    "ghooks": {
      "pre-commit": "if [ -d 'ignite-base' ]; then cd ignite-base; fi; npm run lint"
    }
  }
}

@GantMan
Copy link
Member

GantMan commented May 19, 2017

We're about to release a new version, but you can point the boilerplate to the github repo if you'd like.

@tomaswitek
Copy link
Author

OK I thought so 😏
Thx!!!

@tomaswitek
Copy link
Author

Sorry @GantMan can you pls help me with the command?
ignite new TestApp -b https://github.com/infinitered/ignite-ir-next

returns:

🔥 igniting app TestApp
✖ ignite-https://github.com/infinitered/ignite-ir-next is not available on npm.

If I understand it right I should be able to pass a path instead of name is that correct?
https://github.com/infinitered/ignite/blob/master/src/commands/new.js#L86

@tomaswitek tomaswitek reopened this May 19, 2017
@ruddell
Copy link
Contributor

ruddell commented May 19, 2017

You have to clone the repository first, then use that directory path instead of the url.

@jamonholmgren
Copy link
Member

Yeah, just a path, we don't support git repos at the moment (although that would be cool).

@jamonholmgren
Copy link
Member

We'll be releasing the new Andross this week. infinitered/ignite#1047

@tomaswitek
Copy link
Author

Thank you all for the info 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants