feat: upgrade to Expo SDK 52 #2843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comertcimen
reviewed
Nov 14, 2024
Closed
Closed
frankcalise
commented
Nov 22, 2024
| @@ -26,6 +26,8 @@ module.exports = { | |||
| }, | |||
| ], | |||
| "@typescript-eslint/no-var-requires": 0, | |||
| "@typescript-eslint/no-require-imports": 0, | |||
There was a problem hiding this comment.
Seems like the new eslint rules from Expo turned this on, so I kept it off for consistency.
frankcalise
commented
Nov 22, 2024
| @@ -26,6 +26,8 @@ module.exports = { | |||
| }, | |||
| ], | |||
| "@typescript-eslint/no-var-requires": 0, | |||
| "@typescript-eslint/no-require-imports": 0, | |||
| "@typescript-eslint/no-empty-object-type": 0, | |||
There was a problem hiding this comment.
Seems like the new eslint rules from Expo turned this on. I disabled it because we use this pattern quite a bit with some of the MST helpers.
|
First of all, thank you so much for this @frankcalise For anyone (just like me) wondering to get expo sdk 52 working: npx ignite-cli@latest new MyApp
yarn add expo@^52.0.0
npx expo install --fix
add this to your {
"expo": {
"newArchEnabled": true
}
}and then run npx expo prebuild --clean && npx expo run:android |
…creen styling and drawer fix (#2856 by @frankcalise)
infinitered-circleci
pushed a commit
that referenced
this pull request
Dec 10, 2024
# [10.1.0](v10.0.5...v10.1.0) (2024-12-10) ### Features * upgrade to Expo SDK 52 ([#2843](#2843) by [@frankcalise](https://github.com/frankcalise)) ([fc2b357](fc2b357)), closes [#2856](#2856) [#2862](#2862)
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
CLI
--newArchBoilerplate
npx expo install --fixexpo-splash-screenconfiguration via config plugin (as recommended) over app.jsonsplashkeysreact-native-drawer-layoutpatch now that v4 was releasedreact-native-mmkvversion for new architecture to be compatible with react-native 0.76.x