fix(boilerplate): web platform fixes #2856
Merged
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creen styling and drawer fix
|
Should usePlatformEffect be a more general export? Or is it more important just for the header? |
frankcalise
added a commit
that referenced
this pull request
Dec 10, 2024
* feat: upgrade to Expo SDK 52 * fix(boilerplate): revert mmkv back to v2 for old arch * fix(cli): add `newArch` to cli output * fix(boilerplate): update deps via expo install --fix * fix(boilerplate): disable a few lint rules * chore: deps * chore: ts fixes * fix: return empty array if patches directory does not exist * fix(boilerplate): simplify splash config * chore: update rn * fix(boilerplate): transparent img for splash * fix(boilerplate): web fixes for gesture-handler, useEffect, welcome screen styling and drawer fix (#2856 by @frankcalise) * fix(cli): upgrade yaml pkg to support multi line strings properly (#2862 by @frankcalise) --------- Co-authored-by: Tyler Williams <tyler@coolsoftware.dev> Co-authored-by: Jamon Holmgren <code@jamon.dev>
infinitered-circleci
pushed a commit
that referenced
this pull request
Dec 10, 2024
# [10.1.0](v10.0.5...v10.1.0) (2024-12-10) ### Features * upgrade to Expo SDK 52 ([#2843](#2843) by [@frankcalise](https://github.com/frankcalise)) ([fc2b357](fc2b357)), closes [#2856](#2856) [#2862](#2862)
This was referenced Dec 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
useEffectissue highlighted here: [web] useLayoutEffect + navigating with initial: false causing a crash react-navigation/react-navigation#11748setImmediateissue highlighted here: setImmediate is not defined necolas/react-native-web#1891 (comment)WelcomeScreendisplaying on Web properlytoggleDrawerbeing fired inhandleScrollbecause it was getting caught in a loop (set state is bad in an effect anyway). So the drawer doesn't close upon clicking a nav item but it's much nicer than it not working (plus we have plans to remove the drawer from the demo application)Screenshots (if applicable)
Web
Regression check against mobile devices