Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dist folder before a build to remove any redundant files #909

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haZya
Copy link
Contributor

@haZya haZya commented Nov 26, 2024

Pull Request

Related issue

Fixes #905

What does this PR do?

This removes the additional models folder inside dist directory that is left behind due to not cleaning up the dist folder before doing a rebuild. This will clean up the dist folder on prebuild, which, on the next version of the package, will get rid of the additional models folder that is redundant.

 + This exports the type NSFWJSOptions

@GantMan
Copy link
Member

GantMan commented Nov 30, 2024

@mazenchami - can you put someone on checking this PR? TY sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dist models just increase the size of node_modules unnecessarily (and aren't useful)
2 participants