Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI property #208

Closed
GantMan opened this issue May 23, 2018 · 6 comments · Fixed by #232
Closed

Add CI property #208

GantMan opened this issue May 23, 2018 · 6 comments · Fixed by #232

Comments

@GantMan
Copy link
Member

GantMan commented May 23, 2018

if I set ci to false in the JSON, then ignore that check when running on a machine where the environment has CI=true

This is needed because though a platform matches, some CI's don't have all the needed features. Android/Environment etc. So we'll flag these as OK on CI only.

@harrisrobin
Copy link

Has anyone figured out a workaround for now? 😄

@GantMan
Copy link
Member Author

GantMan commented Dec 1, 2018

I'll see about adding this feature now. Unless you are interested in how to do it @harrisrobin

@GantMan
Copy link
Member Author

GantMan commented Dec 1, 2018

To @harrisrobin 's credit,
image

I'm trying to knock out some outstanding issues today, and I accidentally started with this one. Kudos for the effort, and happy to help you with a separate PR if you're interested

@nonameolsson
Copy link

Would this be the correct usage? The following code fails when I run it as a part of my CI.

    "Git Hooks": [
      {
        "rule": "shell",
        "command": "git config --local --get core.hooksPath",
        "match": ".githooks",
        "error": "Run `git config core.hooksPath .githooks` to add the Git Hooks to your project",
        "ci": false
      }
    ]

@GantMan
Copy link
Member Author

GantMan commented Apr 14, 2019

@nonameolsson - what version do you have?

@nonameolsson
Copy link

@GantMan We use 2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants