Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'inventory' create new version in fluvio test #2085

Closed
sehz opened this issue Jan 7, 2022 · 4 comments
Closed

Update 'inventory' create new version in fluvio test #2085

sehz opened this issue Jan 7, 2022 · 4 comments
Assignees

Comments

@sehz
Copy link
Contributor

sehz commented Jan 7, 2022

This should be updated to 0.2. Just updating cargo.toml cause compilation error

@sehz sehz added this to the 0.9.17 milestone Jan 7, 2022
@nacardin nacardin modified the milestones: 0.9.17, 0.10.0 Jan 10, 2022
@tjtelan
Copy link
Contributor

tjtelan commented May 17, 2022

It appears this crate is being deprecated?
The repo and others related were made readonly https://github.com/dtolnay/inventory

More background:
https://www.reddit.com/r/rust/comments/sjrt8f/dtolnayinventory_got_archived_is_there_an/
rust-lang/rust#47384 (comment)

@morenol
Copy link
Contributor

morenol commented Jul 4, 2022

We should retry with new version

@sehz sehz removed this from the 0.10.0 milestone Jul 5, 2022
@sehz
Copy link
Contributor Author

sehz commented Jul 5, 2022

@tjtelan can you look into this?

@tjtelan
Copy link
Contributor

tjtelan commented Jul 6, 2022

I just tried to swap out 0.1 for 0.3 and it looks like there's an incompatibility w/ the macro implementation using .to_string(). Will need to look into the proc macro.

error[E0015]: cannot call non-const fn `<str as ToString>::to_string` in statics
  --> crates/fluvio-test/src/tests/self_test/mod.rs:46:1
   |
46 | #[fluvio_test()]
   | ^^^^^^^^^^^^^^^^
   |
   = note: calls in statics are limited to constant functions, tuple structs and tuple variants
   = note: this error originates in the attribute macro `fluvio_test` (in Nightly builds, run with -Z macro-backtrace for more info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants