Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace prettytable-rs with another simple table formatter #2263

Closed
tjtelan opened this issue Mar 22, 2022 · 1 comment
Closed

Replace prettytable-rs with another simple table formatter #2263

tjtelan opened this issue Mar 22, 2022 · 1 comment
Assignees
@suptejas
Labels
CLI DX/GENERAL Developer Experience General good first issue Good for newcomers help wanted Good issue for community involvement technical debt
Milestone
0.9.24

Comments

@tjtelan
Copy link
Contributor

tjtelan commented Mar 22, 2022

It seems that prettytable-rs has been abandoned and there's a PR for adding it to RustSec Advisory Database.

There are no current reports of CLI issues related to prettytable, so I don't think this is urgent. But since there are a lot of choices for replacements, I think this might come down to personal preferences.

We should balance to keep the table render as close as possible with minimal code changes.
@tjtelan tjtelan added help wanted Good issue for community involvement good first issue Good for newcomers CLI technical debt Priority/low DX/GENERAL Developer Experience General labels Mar 22, 2022
@suptejas suptejas linked a pull request Apr 9, 2022 that will close this issue
[Merged by Bors] - Migrate to comfy-table #2285
Closed
@sehz sehz added this to the 0.9.24 milestone Apr 14, 2022
@sehz
Copy link
Contributor

sehz commented Apr 16, 2022

done

@sehz sehz closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suptejas suptejas

Labels
CLI DX/GENERAL Developer Experience General good first issue Good for newcomers help wanted Good issue for community involvement technical debt
Projects
None yet
Milestone
0.9.24
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Migrate to comfy-table
3 participants
@tjtelan @sehz @suptejas