[Merged by Bors] - feat: support custom configs in connector SDK #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
reviewed
Dec 29, 2022
sehz
reviewed
Dec 29, 2022
|
Added an ability to specify the custom configuration in connector package metadata. OpenApi spec is used, so complex objects can be defined as well. The validation honors this specification. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
`connector` macro will support any custom configs for connectors. It is done in the following way: 1. Config file is read and parsed to `serde_yaml::Value`. 2. `ConnectorConfig` is parsed from the yaml value and used to initialize Producer/Consumer. 3. User-defined config is parsed from the yaml value and passed to the user-defined function. Validation on the deployer side is done only for `ConnectorConfig` type. Each connector will be responsible for the validation of its own configs.
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
`connector` macro will support any custom configs for connectors. It is done in the following way: 1. Config file is read and parsed to `serde_yaml::Value`. 2. `ConnectorConfig` is parsed from the yaml value and used to initialize Producer/Consumer. 3. User-defined config is parsed from the yaml value and passed to the user-defined function. Validation on the deployer side is done only for `ConnectorConfig` type. Each connector will be responsible for the validation of its own configs.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connectormacro will support any custom configs for connectors.It is done in the following way:
serde_yaml::Value.ConnectorConfigis parsed from the yaml value and used to initialize Producer/Consumer.Validation on the deployer side is done only for
ConnectorConfigtype.Each connector will be responsible for the validation of its own configs.