[Merged by Bors] - refactor: remove unnecessary bounds for encoder and decoder derive macro #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
changed the title
sehz
force-pushed
the
refactor_protocol_min
branch
from
12a54ed
to
f8ca579
Compare
sehz
force-pushed
the
refactor_protocol_min
branch
from
f8ca579
to
5ad0552
Compare
sehz
force-pushed
the
refactor_protocol_min
branch
from
a17c217
to
0eebfc9
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
…cro (#3030) Fixed a long standing tech debt around Encoder and Decoder derived macro. With this fix, no longer need to add bounds to struct as before: ``` pub struct Message<C> where C: Encoder + Decoder + Debug, { pub header: MsgType, pub content: C, } ``` Instead, this can be simplified: ``` pub struct Message<C> { pub header: MsgType, pub content: C, } ``` Forcing to add structure bounds cause downstream code to deal with extras bounds which make certain implementation difficult if not outright implementation In addition, tracing code is only added if enabled. This should only necessary in development. This will reduce some code and improve performance slightly. ``` #[derive(Encoder,Decoder,Default] #[fluvio(trace)] MyStruct { ... } ```
|
not sure if we should merge this yet, since not sure if we need to do fluvio release again |
|
reverting release should be only done in rare circumstances. next time, we should do another release. |
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a long standing tech debt around Encoder and Decoder derived macro.
With this fix, no longer need to add bounds to struct as before:
Instead, this can be simplified:
Forcing to add structure bounds cause downstream code to deal with extras bounds which make certain implementation difficult if not outright implementation
In addition, tracing code is only added if enabled. This should only necessary in development. This will reduce some code and improve performance slightly.