Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: use .hub over hub and delete if exists #3193

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: use .hub over hub and delete if exists #3193

wants to merge 1 commit into from

Conversation

EstebanBorai
Copy link
Contributor

Ensures the Package Metadata Directory is recreated before publishing
a package to the hub.

@EstebanBorai EstebanBorai linked an issue Apr 25, 2023 that may be closed by this pull request
SMDK: re-generate pkg manifest instead of re-using for publishing #3186
Closed
@EstebanBorai EstebanBorai marked this pull request as ready for review April 25, 2023 17:58
sehz
sehz approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2023
@EstebanBorai
fix: use .hub over hub and delete if exists (#3193)
07de956 
Ensures the Package Metadata Directory is recreated before publishing
a package to the hub.
@bors
Copy link

bors bot commented Apr 25, 2023

Build failed:

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2023
@EstebanBorai
fix: use .hub over hub and delete if exists (#3193)
f05b887 
Ensures the Package Metadata Directory is recreated before publishing
a package to the hub.
@bors
Copy link

bors bot commented Apr 25, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: use .hub over hub and delete if exists [Merged by Bors] - fix: use .hub over hub and delete if exists Apr 25, 2023
@bors bors bot closed this Apr 25, 2023
@sehz sehz modified the milestone: 0.10.8 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@digikata digikata Awaiting requested review from digikata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SMDK: re-generate pkg manifest instead of re-using for publishing
2 participants
@EstebanBorai @sehz