[Merged by Bors] - fix: fix fluvio hub utils #3198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
force-pushed
the
fix-fluvio-hub-util
branch
from
f355165
to
a9e2574
Compare
|
The global const is fine, but the reason for "PUBLIC KEY" and "PRIVATE KEY" with spaces is that those tags matched openssh generated key formats. |
Right! I updated the consts to have the space in the tag. The issue right now is the difference between let pem = Pem::new("PRIVATE_KEY", self.kp.secret.to_bytes().to_vec());with: if pem.tag() != "PRIVATE KEY" {Should I keep the tag without the underscore, right? |
|
I took a longer look at it this morning and last night I was looking at the wrong key fmt, I think its good! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
In the update of `pem` fdcfce5 to `2.0.0`. It was changed the tag from `PUBLIC KEY` and `PRIVATE KEY` to `PUBLIC_KEY` and `PRIVATE_KEY`. This changes uses a global const so we use the same tag when we write to file and when we read from file
digikata
approved these changes
Apr 27, 2023
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the update of
pemfdcfce5 to2.0.0. It was changed the tag fromPUBLIC KEYandPRIVATE KEYtoPUBLIC_KEYandPRIVATE_KEY. This changes uses a global const so we use the same tag when we write to file and when we read from file