Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - remove deprecated code related to clap #3228

Closed
wants to merge 2 commits into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented May 5, 2023

I enabled deprecated feature for clap. Fixed all the warning and then removed that feature again

@morenol morenol changed the title remove deprecated code from fluvio remove deprecated code related to clap May 5, 2023
@morenol morenol requested a review from sehz May 8, 2023 14:56
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sehz sehz added this to the 0.10.9 milestone May 8, 2023
@morenol
Copy link
Contributor Author

morenol commented May 8, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 8, 2023
I enabled deprecated feature for clap. Fixed all the warning and then removed that feature again
@bors
Copy link

bors bot commented May 8, 2023

Build failed:

@morenol
Copy link
Contributor Author

morenol commented May 8, 2023

bors retry

bors bot pushed a commit that referenced this pull request May 8, 2023
I enabled deprecated feature for clap. Fixed all the warning and then removed that feature again
@morenol
Copy link
Contributor Author

morenol commented May 8, 2023

bors r-

@bors
Copy link

bors bot commented May 8, 2023

Canceled.

@morenol
Copy link
Contributor Author

morenol commented May 8, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 8, 2023
I enabled deprecated feature for clap. Fixed all the warning and then removed that feature again
@bors
Copy link

bors bot commented May 8, 2023

Build failed:

@morenol
Copy link
Contributor Author

morenol commented May 8, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 8, 2023
I enabled deprecated feature for clap. Fixed all the warning and then removed that feature again
@bors
Copy link

bors bot commented May 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title remove deprecated code related to clap [Merged by Bors] - remove deprecated code related to clap May 8, 2023
@bors bors bot closed this May 8, 2023
@morenol morenol deleted the clap-remove-deprecated-code branch May 8, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants