Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Infer target for cdk deploy #3247

Closed
wants to merge 5 commits into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented May 11, 2023

No description provided.

@morenol morenol requested a review from EstebanBorai May 11, 2023 21:35
Comment on lines 171 to +174
assert!(package_info
.target_bin_path()
.unwrap()
.ends_with("release-lto/cargo-builder"));
.ends_with("x86_64-unknown-linux-gnu/release-lto/cargo-builder"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morenol
Copy link
Contributor Author

morenol commented May 12, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 12, 2023
@bors
Copy link

bors bot commented May 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Infer target for cdk deploy [Merged by Bors] - Infer target for cdk deploy May 12, 2023
@bors bors bot closed this May 12, 2023
@morenol morenol deleted the cdk-deploy branch May 12, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants