Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(spu): added smart engine memory limit #3407

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(spu): added smart engine memory limit #3407

wants to merge 1 commit into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Jul 20, 2023

Added a memory limit for smartmodules and an ability to specify it on SPU config.

Default value is set to 1 Gb. Can be overridden by passing SPU cli argument:
fluvio-run spu ... --smart-engine-max-memory N

Fixes #3406

Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nice code readability cleanup too

@galibey
Copy link
Contributor Author

galibey commented Jul 21, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 21, 2023
Added a memory limit for smartmodules and an ability to specify it on SPU config.

Default value is set to 1 Gb. Can be overridden by passing SPU cli argument:
 `fluvio-run spu ... --smart-engine-max-memory N` 

Fixes #3406
@bors
Copy link

bors bot commented Jul 21, 2023

Build failed:

@galibey
Copy link
Contributor Author

galibey commented Jul 21, 2023

bors retry

bors bot pushed a commit that referenced this pull request Jul 21, 2023
Added a memory limit for smartmodules and an ability to specify it on SPU config.

Default value is set to 1 Gb. Can be overridden by passing SPU cli argument:
 `fluvio-run spu ... --smart-engine-max-memory N` 

Fixes #3406
@bors
Copy link

bors bot commented Jul 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(spu): added smart engine memory limit [Merged by Bors] - feat(spu): added smart engine memory limit Jul 21, 2023
@bors bors bot closed this Jul 21, 2023
@galibey galibey deleted the feat/set-smartengine-store-limits branch July 21, 2023 08:38
@digikata digikata added this to the 0.10.14 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add memory limits control to SmartEngines
2 participants