-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Unify common dependencies #3442
Conversation
c101a12
to
225aeb8
Compare
Looks like https://github.com/infinyon/fluvio/actions/runs/5754781767/job/15601307131 was spurious but now https://github.com/infinyon/fluvio/actions/runs/5788343499/job/15687610521?pr=3442 is showing a version mismatch. Needs more investigation on my side. |
@EstebanBorai CI looks OK now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @c410-f3r! Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good except trybuild
on a repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
bors r+ |
Thank you guys! |
Continuation of #3408 To the best of my knowledge, all common dependencies are now sharing the same workspace definition.
Build failed: |
Error looks spurious |
bors r+ |
Merge conflict. |
@c410-f3r I just added a commit to solve conflicts with the changes of the last PR bors r+ |
Continuation of #3408 To the best of my knowledge, all common dependencies are now sharing the same workspace definition. Co-authored-by: morenol <22335041+morenol@users.noreply.github.com>
Build failed: |
bors retry |
Continuation of #3408 To the best of my knowledge, all common dependencies are now sharing the same workspace definition. Co-authored-by: morenol <22335041+morenol@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Thank you @morenol ! |
Continuation of #3408
To the best of my knowledge, all common dependencies are now sharing the same workspace definition.