Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use utc timestamp in cli-smdk-basic-test #3574

Conversation

matheus-consoli
Copy link
Contributor

Some tests were failing in some parts of the day because they used date, which gives the local time, to compare with a UTC timestamp.

@sehz sehz added this to the 0.11.0 milestone Oct 4, 2023
@sehz sehz added CLI technical debt Test Infrastructure Testing infrastructure and removed CLI labels Oct 4, 2023
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch

@sehz
Copy link
Contributor

sehz commented Oct 4, 2023

bors r+

bors bot pushed a commit that referenced this pull request Oct 4, 2023
Some tests were failing in some parts of the day because they used `date`, which gives the local time, to compare with a UTC timestamp.
@bors
Copy link

bors bot commented Oct 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Use utc timestamp in cli-smdk-basic-test [Merged by Bors] - Use utc timestamp in cli-smdk-basic-test Oct 4, 2023
@bors bors bot closed this Oct 4, 2023
@matheus-consoli matheus-consoli deleted the smdk-basic-test-timestamp branch October 4, 2023 21:30
@sehz sehz modified the milestones: 0.11.0, 0.10.16 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants