[Merged by Bors] - feat: fvm switch command #3597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanBorai
commented
Oct 12, 2023
| export PATH="$PATH:$HOME/.fvm/bin" | ||
| export PATH="$PATH:$HOME/.fvm/bin:$HOME/.fluvio/bin" |
There was a problem hiding this comment.
This allows the user to have both:
~/.fvm/bin~/.fluvio/bin
In their PATH after executing source ~/.fvm/env
EstebanBorai
commented
Oct 12, 2023
EstebanBorai
commented
Oct 12, 2023
digikata
reviewed
Oct 12, 2023
sehz
requested changes
Oct 12, 2023
EstebanBorai
force-pushed
the
3596-fvm-switch-fluvio-versions
branch
from
2c506b7
to
5d03acc
Compare
|
I just addressed suggestions here: 5d03acc! |
sehz
requested changes
Oct 13, 2023
crates/fluvio-version-manager/src/command/switch/version_directory.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-version-manager/src/command/switch/version_directory.rs
Outdated
Show resolved
Hide resolved
EstebanBorai
force-pushed
the
3596-fvm-switch-fluvio-versions
branch
2 times, most recently
from
c8f9ef2
to
313df57
Compare
EstebanBorai
force-pushed
the
3596-fvm-switch-fluvio-versions
branch
3 times, most recently
from
65f2b91
to
4216b72
Compare
sehz
requested changes
Oct 13, 2023
crates/fluvio-version-manager/src/command/switch/version_directory.rs
Outdated
Show resolved
Hide resolved
crates/fluvio-version-manager/src/command/switch/version_directory.rs
Outdated
Show resolved
Hide resolved
EstebanBorai
force-pushed
the
3596-fvm-switch-fluvio-versions
branch
from
4216b72
to
23d73d9
Compare
sehz
reviewed
Oct 14, 2023
- Check manifest integrity by using a `VersionManifest` instance instead of a `PathBuf` to the manifest - Borrow over clone on `SwitchOpt` version - Clarifications on procedures - Isolate `update_settings_toml` to test independently - Ensure files are copied to target directory - Use string literal in tests for comparison - Duplicate user's flow in E2E test - Uses inline invalid Manifest JSON (impl `FromStr`) - Readback `Settings` after create and assert on values - Introduce fixtures for PackageSet - Move `switch` logic to `VersionDirectory` - Use hardcoded Shasums to test against - Perform exact comparison for Sha256 Checksums - Introduce `update_from_manifest` to update `settings.toml` form a `VersionManifest` - Verify updates in `settings.toml` with E2E Smoke Tests - Compare Sha256Sum on E2E Smoke Tests - Move `Settings` `update_from_manifest` to `VersionManager` - Use simple file to test shasums - Explicit tests on single file - Test settings is updated on `set_active`
EstebanBorai
force-pushed
the
3596-fvm-switch-fluvio-versions
branch
from
23d73d9
to
d11f3e5
Compare
sehz
approved these changes
Oct 14, 2023
🙌🏻
Looking forward into it! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 14, 2023
Provides support to switch between Fluvio Versions using `fvm switch` command. The `fvm switch` command performs a side effect which involves updating `settings.toml` file in `~/.fvm` which is used to keep track of the active channel and version. Also updates the `~/.fvm/env` file to include `~/.fluvio/bin` in the host's PATH when running `source ~/.fvm/env`. ## Demo https://github.com/infinyon/fluvio/assets/34756077/f81960ee-b557-4720-8691-8f4afb79a84f Co-authored-by: Alan Chen <alan@infinyon.com>
|
Build failed: |
|
Errors doesn't look related to PR: https://github.com/infinyon/fluvio/actions/runs/6520022049/job/17707174387#step:5:1107 So I will rerun! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 14, 2023
Provides support to switch between Fluvio Versions using `fvm switch` command. The `fvm switch` command performs a side effect which involves updating `settings.toml` file in `~/.fvm` which is used to keep track of the active channel and version. Also updates the `~/.fvm/env` file to include `~/.fluvio/bin` in the host's PATH when running `source ~/.fvm/env`. ## Demo https://github.com/infinyon/fluvio/assets/34756077/f81960ee-b557-4720-8691-8f4afb79a84f Co-authored-by: Alan Chen <alan@infinyon.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
This was
linked to
issues
Oct 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support to switch between Fluvio Versions using
fvm switchcommand.The
fvm switchcommand performs a side effect which involves updatingsettings.tomlfile in
~/.fvmwhich is used to keep track of the active channel and version.Also updates the
~/.fvm/envfile to include~/.fluvio/binin the host's PATHwhen running
source ~/.fvm/env.Demo
demo.mp4