Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(fvm): set version as active after install #3604

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Oct 17, 2023

fvm install now sets the installed version as active


Demo

fvm-install-switch.mp4

@EstebanBorai EstebanBorai linked an issue Oct 17, 2023 that may be closed by this pull request
@EstebanBorai EstebanBorai force-pushed the 3602-fvm-set-installed-version-as-active branch from b50171c to 8e3b28e Compare October 17, 2023 14:46
@EstebanBorai EstebanBorai force-pushed the 3602-fvm-set-installed-version-as-active branch from 8e3b28e to 936ebae Compare October 17, 2023 15:04
@EstebanBorai EstebanBorai marked this pull request as ready for review October 17, 2023 15:20
@EstebanBorai EstebanBorai linked an issue Oct 17, 2023 that may be closed by this pull request
20 tasks
@EstebanBorai
Copy link
Contributor Author

@digikata I just cherry-picked your commit 5e5c45c here!

Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit

tests/cli/fvm_smoke_tests/fvm_basic.bats Outdated Show resolved Hide resolved
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 17, 2023
`fvm install` now sets the installed version as active

---

## Demo

https://github.com/infinyon/fluvio/assets/34756077/4aea12c9-dd0d-46ee-9780-483036e9abf7




Co-authored-by: Alan Chen <alan@infinyon.com>
@bors
Copy link

bors bot commented Oct 17, 2023

Build failed:

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 17, 2023
`fvm install` now sets the installed version as active

---

## Demo

https://github.com/infinyon/fluvio/assets/34756077/4aea12c9-dd0d-46ee-9780-483036e9abf7




Co-authored-by: Alan Chen <alan@infinyon.com>
@bors
Copy link

bors bot commented Oct 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(fvm): set version as active after install [Merged by Bors] - feat(fvm): set version as active after install Oct 17, 2023
@bors bors bot closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FVM - Set installed version as active Fluvio Version Manager
3 participants