[Merged by Bors] - fix(fvm): partially assert on cli output #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanBorai
force-pushed
the
fix/tests-output-asserts
branch
from
0b98c98
to
dae597f
Compare
EstebanBorai
changed the title
digikata
approved these changes
Oct 18, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
Currently our tests expects download output in a specific order when executing `fvm install`. This breaks if changes on responses are introduced, to avoid this we could partially assert on the text output. This only happens on the `fvm install` command as it depends on server response to render its output. ## Example of Broken Test ``` 2023-10-18T15:25:09.8470954Z not ok 9 Supress output with '-q' optional argument 2023-10-18T15:25:09.8483122Z # (from function `assert_line' in file tests/cli/fvm_smoke_tests/../test_helper/bats-assert/src/assert_line.bash, line 202, 2023-10-18T15:25:09.8487786Z # in test file tests/cli/fvm_smoke_tests/fvm_basic.bats, line 479) 2023-10-18T15:25:09.8546282Z # `assert_line --index 3 "info: Downloading (4/5): cdk@0.10.14"' failed 2023-10-18T15:25:09.8554999Z # 2023-10-18T15:25:09.8555778Z # -- line differs -- 2023-10-18T15:25:09.8556427Z # index : 3 2023-10-18T15:25:09.8557991Z # expected : info: Downloading (4/5): cdk@0.10.14 2023-10-18T15:25:09.8558937Z # actual : info: Downloading (4/5): smdk@0.10.14 2023-10-18T15:25:09.8607628Z # - ```
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our tests expects download output in a specific order when executing
fvm install. This breaks if changes on responses are introduced, to avoid thiswe could partially assert on the text output.
This only happens on the
fvm installcommand as it depends on server responseto render its output.
Example of Broken Test