[Merged by Bors] - feat: deprecatefluvio install
#3655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f0f4968.
|
@tjtelan I added a deprecation notice on Do you have any recommendations on a documentation link to point to as part of the warning message? As we release this on |
EstebanBorai
commented
Nov 2, 2023
Comment on lines
+55
to
+56
| println!("warning: `fluvio install` is deprecated, use `fvm install` instead."); | ||
| println!("Refer to https://www.fluvio.io/docs/get-started/linux/#install-fluvio-cli"); |
There was a problem hiding this comment.
Adds deprecation notice and link to install docs.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
Deprecates `fluvio install` to use `fvm install` instead.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
fluvio installfluvio install
vrrashkov
pushed a commit
to vrrashkov/fluvio
that referenced
this pull request
Nov 3, 2023
Deprecates `fluvio install` to use `fvm install` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
fluvio installto usefvm installinstead.