Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: use store version on metadata stream filter #3664

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: use store version on metadata stream filter #3664

wants to merge 1 commit into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Nov 3, 2023

The metadata watch stream was mistakenly filtering by a spec version when it should filter by store version.

@galibey galibey self-assigned this Nov 3, 2023
@galibey galibey requested a review from sehz November 3, 2023 13:52
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galibey
Copy link
Contributor Author

galibey commented Nov 3, 2023

bors r+

bors bot pushed a commit that referenced this pull request Nov 3, 2023
The metadata watch stream was mistakenly filtering by a spec version when it should filter by store version.
Copy link

bors bot commented Nov 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: use store version on metadata stream filter [Merged by Bors] - fix: use store version on metadata stream filter Nov 3, 2023
@bors bors bot closed this Nov 3, 2023
@galibey galibey deleted the fix/wrong-version-metadata-watch-stream branch November 3, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants