feat: fvm user interface improvements #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EstebanBorai
commented
Nov 10, 2023
Comment on lines
+72
to
+83
| if version.is_version_tag() { | ||
| notify.done(format!( | ||
| "Now using Fluvio version {}", | ||
| version.to_string().bold(), | ||
| )); | ||
| } else { | ||
| notify.done(format!( | ||
| "Now using Fluvio {} ({})", | ||
| version.to_string().bold(), | ||
| version_dir.manifest.version.to_string().bold(), | ||
| )); | ||
| } |
There was a problem hiding this comment.
For version tags, say fvm switch 0.10.11, rendering the tag between parenthesis is redundant so its discriminated by the nature of the Channel instance provided.
We just want to render the specific tag for Channels.
fvm switch 0.10.15
...
done: Now using Fluvio version 0.10.15And with Channels
fvm switch stable
...
done: Now using Fluvio stable (0.10.17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple of very small changes in FVM to make the UI more intuitive.
fvm listoverfvm showfor listing installed versions (4ad1b91)Demo
Using switch on Channels now prints the underlying tag
Now `fvm list` is used to list versions