Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly pass owner references in conversions #3702

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: properly pass owner references in conversions #3702

merged 1 commit into from
Nov 15, 2023

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Nov 14, 2023

There were two places where owner_references were lost after conversions:

  1. From ObjectMeta to K8MetaItem if resource_version is empty.
  2. InputObjectMeta = ObjectMeta::into() does not pass owner_references, instead need to use ObjectMeta::as_input()

@galibey galibey self-assigned this Nov 14, 2023
nacardin
nacardin approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@nacardin nacardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my test!

@EstebanBorai EstebanBorai added this pull request to the merge queue Nov 15, 2023
Merged via the queue into infinyon:master with commit 1fc1195 Nov 15, 2023
104 checks passed
@galibey galibey deleted the fix/owner-references-lost-in-conversion branch November 15, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nacardin nacardin nacardin approved these changes

Assignees

@galibey galibey

Labels
k8/general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galibey @nacardin @EstebanBorai