chore: update local clusters setup on CD and Hourly #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digikata
approved these changes
Nov 20, 2023
Comment on lines
-106
to
-110
| if [[ ${{ matrix.os }} == 'macos-12' ]]; then | ||
| export PROXY="--proxy-addr 127.0.0.1" | ||
| else | ||
| export PROXY="" | ||
| fi |
There was a problem hiding this comment.
Does the macos-12 k8 not need the PROXY variable anymore? The other removal of PROXY below sets proxy always, so it's not clear if macos uniquely needs a PROXY or if all os combos will use it on some tests?
There was a problem hiding this comment.
In CD_DEV we no longer have macos-12 as os, only ubuntu-latest, so I removed dead code.
in both CD_DEV and CD_DEV_Mac I removed the condition with PROXY and added the actual proxy argument to the start command on CD_DEV_Mac.
--proxy-addr 127.0.0.1 is always needed for macos, and is not needed for ubuntu.
tjtelan
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CD_DEVandCD_DEV_Mac- do not install k8s for local clusters, explicitly set installation type so it won't be broken when defaults change.Hourly- added local cluster to longevity tests, set it to every 2 hours instead of every hour to compensate for increased CI time.