Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version checker for Resume #3999

Merged
merged 10 commits into from
May 14, 2024
Merged

Version checker for Resume #3999

merged 10 commits into from
May 14, 2024

Conversation

avikam
Copy link
Contributor

@avikam avikam commented May 9, 2024 •
edited
Loading

Issue: #3989

when resuming a cluster, we first check if the CLI version is compatible with the installed version.
The compatibility logic remained the same (exact version match).

The PR also refactors the SC-connection function - added exponential backoff logic and removed duplicated code

> fluvio cluster shutdown
Removed spu monitoring socket: /tmp/fluvio-spu.sock
Uninstalled fluvio local components
> sed -i .BAK 's/platform_version = "\([^"]*\)"/platform_version = "\1-dummy"/g' ~/.fluvio/local-config

> fluvio cluster resume
 -                                                                                                                                                                                                                                                                               ✅ Local Fluvio is not installed
    ❌ Check Versions match failed Must have local platform version 0.11.9-dev. You have 0.11.9-dev-dummy.
💔 Some pre-flight check failed!
❌ Resume failed with Preflight check failed

@avikam avikam force-pushed the avikam/resume-version-check branch from 740021d to 5fa0acf Compare May 9, 2024 18:07
@avikam avikam force-pushed the avikam/resume-version-check branch from 5fa0acf to b7c2282 Compare May 9, 2024 18:15
@avikam avikam force-pushed the avikam/resume-version-check branch from 03646bc to 6e56a1f Compare May 9, 2024 18:21
@avikam avikam mentioned this pull request May 9, 2024
Closed
@avikam avikam marked this pull request as ready for review May 10, 2024 17:22
sehz
sehz requested changes May 11, 2024
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. a minor nit

crates/fluvio-cluster/src/start/common.rs Outdated Show resolved Hide resolved
crates/fluvio-cluster/src/start/common.rs Show resolved Hide resolved
sehz
sehz approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Nice job. thanks

digikata
digikata approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR & that last fixup

@digikata digikata added this pull request to the merge queue May 14, 2024
Merged via the queue into infinyon:master with commit f773515 May 14, 2024
103 checks passed
@avikam avikam deleted the avikam/resume-version-check branch May 14, 2024 16:29
fraidev pushed a commit to fraidev/fluvio that referenced this pull request May 23, 2024
@avikam @fraidev
Version checker for Resume (infinyon#3999)
85f8165 
* adding version checker

* fix delay and timemout numbers

* addressed comments

* exp back-off

* reuse timeout code

* debug print

* wording
@digikata digikata mentioned this pull request Jul 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@digikata digikata digikata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avikam @digikata @sehz