Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export mirror file with tls #4016

Merged
merged 4 commits into from
May 22, 2024
Merged

feat: export mirror file with tls #4016

merged 4 commits into from
May 22, 2024

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented May 22, 2024 •
edited
Loading

Example:

fluvio remote register user1 
fluvio remote export user1 --file user1.json --key ~/workspace/infinyon/fluvio/tls/certs/client-user1.key --cert ~/workspace/infinyon/fluvio/tls/certs/client-user1.crt

@fraidev fraidev mentioned this pull request May 22, 2024
Merged
1 task
@fraidev fraidev requested a review from sehz May 22, 2024 14:48
sehz
sehz requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should have CLI test as well

crates/fluvio-cli/src/client/remote/export.rs
}
_ => Ok(None),
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

crates/fluvio-controlplane-metadata/src/mirror/spec.rs
@@ -75,4 +75,25 @@ pub struct Home {
pub id: String,
pub remote_id: String,
pub public_endpoint: String,
#[cfg_attr(feature = "use_serde", serde(skip_serializing_if = "Option::is_none"))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should be called client_tls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

k8-util/helm/fluvio-sys/templates/crd_mirror.yaml
@@ -46,6 +46,17 @@ spec:
type: string
publicEndpoint:
type: string
tls:
type: object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client_tls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@fraidev fraidev marked this pull request as ready for review May 22, 2024 15:34
@fraidev
Copy link
Contributor Author

fraidev commented May 22, 2024

also should have CLI test as well

end to end with bats files?

sehz
sehz approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fraidev fraidev added this pull request to the merge queue May 22, 2024
Merged via the queue into infinyon:master with commit 9bf976d May 22, 2024
103 checks passed
@fraidev fraidev deleted the mirroring_auth_1 branch May 22, 2024 18:19
fraidev added a commit to fraidev/fluvio that referenced this pull request May 23, 2024
@fraidev
feat: export mirror file with tls (infinyon#4016)
7fc28d3 
* chore: add tls to home metadata

* feat: export mirror file with tls

* test: add unit tests to get tls config export

* test: add cli tests for export mirroring
This was referenced May 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fraidev @sehz