Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fvm): fvm self update support #4020

Merged

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented May 22, 2024

Provides support to update FVM with fvm self update.

Current behavior doesn't check for "greater" versions, but instead just checks if versions
are different. By default stable fvm channel is checked.

In order to overwrite the version to update of FVM an environment variable
FVM_UPDATE_VERSION can be used to provide the tag to be used at the moment of fetching
the FVM version.

Demo

demo.mp4

@EstebanBorai EstebanBorai force-pushed the 3993-fvm-self-update-should-perform-update-process branch 4 times, most recently from 0c0ef08 to eceea7c Compare May 24, 2024 00:54
@EstebanBorai EstebanBorai linked an issue May 24, 2024 that may be closed by this pull request
@EstebanBorai EstebanBorai force-pushed the 3993-fvm-self-update-should-perform-update-process branch 4 times, most recently from b940f29 to c705000 Compare May 27, 2024 15:27
@EstebanBorai EstebanBorai force-pushed the 3993-fvm-self-update-should-perform-update-process branch from c705000 to ddaa43d Compare May 27, 2024 15:43
@EstebanBorai EstebanBorai marked this pull request as ready for review May 27, 2024 16:28
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one minor refactor to consider.

crates/fluvio-version-manager/src/common/executable.rs Outdated Show resolved Hide resolved
@EstebanBorai EstebanBorai added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@EstebanBorai EstebanBorai added this pull request to the merge queue May 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 28, 2024
* feat(fvm): `fvm self update` support

* feat: use sha256digest from fluvio-hub-util
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@EstebanBorai EstebanBorai added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit 8792eb9 May 28, 2024
103 checks passed
@EstebanBorai EstebanBorai deleted the 3993-fvm-self-update-should-perform-update-process branch May 28, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fvm self update should perform update process
2 participants