-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add mirroring e2e test #4028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
mirroring_e2e_tests
branch
14 times, most recently
from
May 25, 2024 17:16
4a8b855
to
0675d0d
Compare
sehz
requested changes
May 25, 2024
fraidev
force-pushed
the
mirroring_e2e_tests
branch
from
May 27, 2024 03:28
0675d0d
to
dcd3df0
Compare
This was referenced May 27, 2024
fraidev
force-pushed
the
mirroring_e2e_tests
branch
5 times, most recently
from
May 29, 2024 00:19
7bcc008
to
9750143
Compare
sehz
reviewed
May 29, 2024
sehz
requested changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job! Just need couple of more things to address
fraidev
force-pushed
the
mirroring_e2e_tests
branch
from
May 29, 2024 01:49
9750143
to
0029bbb
Compare
fraidev
force-pushed
the
mirroring_e2e_tests
branch
4 times, most recently
from
May 29, 2024 03:35
b59726f
to
30d5676
Compare
sehz
reviewed
May 29, 2024
fraidev
force-pushed
the
mirroring_e2e_tests
branch
8 times, most recently
from
May 29, 2024 05:33
8a2ea02
to
31b5ad5
Compare
fraidev
force-pushed
the
mirroring_e2e_tests
branch
from
May 29, 2024 05:46
31b5ad5
to
5b8b23a
Compare
sehz
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough coverage
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should cover an initial structure to write e2e tests for mirroring.
The CI should start a local cluster and a k8s cluster.
The test should use k8s as home and local as remote.