Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add mirroring e2e test #4028

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented May 24, 2024

This PR should cover an initial structure to write e2e tests for mirroring.

The CI should start a local cluster and a k8s cluster.

The test should use k8s as home and local as remote.

@fraidev fraidev force-pushed the mirroring_e2e_tests branch 14 times, most recently from 4a8b855 to 0675d0d Compare May 25, 2024 17:16
@fraidev fraidev marked this pull request as ready for review May 25, 2024 17:52
@fraidev fraidev requested review from sehz and digikata May 25, 2024 17:53
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job! Just need couple of more things to address

@fraidev fraidev force-pushed the mirroring_e2e_tests branch 4 times, most recently from b59726f to 30d5676 Compare May 29, 2024 03:35
@fraidev fraidev force-pushed the mirroring_e2e_tests branch 8 times, most recently from 8a2ea02 to 31b5ad5 Compare May 29, 2024 05:33
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough coverage

@fraidev fraidev added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@fraidev fraidev added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@fraidev fraidev added this pull request to the merge queue May 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@fraidev fraidev added this pull request to the merge queue May 29, 2024
Merged via the queue into infinyon:master with commit b45b5a4 May 29, 2024
104 checks passed
@fraidev fraidev deleted the mirroring_e2e_tests branch May 29, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants