Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mirror remote #4097

Merged
merged 2 commits into from
Jul 12, 2024
Merged

feat: add mirror remote #4097

merged 2 commits into from
Jul 12, 2024

Conversation

fraidev
Copy link
Contributor

@fraidev fraidev commented Jul 9, 2024 •
edited
Loading

This PR must allow these commands:

fluvio remote register edge1
fluvio topic create mirror-topic --mirror
fluvio topic add-mirror mirror-topic edge1

Related: #4039

@fraidev fraidev force-pushed the mirror_add_remote branch 2 times, most recently from d411f97 to f692932 Compare July 11, 2024 23:44
@fraidev fraidev marked this pull request as ready for review July 12, 2024 00:21
@fraidev fraidev requested review from sehz and digikata July 12, 2024 00:23
digikata
digikata approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good that supporting tests were added too!

@fraidev fraidev added this pull request to the merge queue Jul 12, 2024
Merged via the queue into infinyon:master with commit 5c551d5 Jul 12, 2024
104 checks passed
@fraidev fraidev deleted the mirror_add_remote branch July 12, 2024 15:40
@fraidev fraidev mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

@sehz sehz Awaiting requested review from sehz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fraidev @digikata