Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization: TableLayer: update interface to avoid double parsing #787

Open
TCL735 opened this issue Aug 3, 2022 · 1 comment
Open

Comments

@TCL735
Copy link
Contributor

TCL735 commented Aug 3, 2022

The way it is now:
Some applications that consume Giraffe will do the parsing of a fluxResponse as part of the response handling prior to any interaction with Giraffe. For such applications, rendering a TableLayer through Giraffe means re-sending the fluxResponse to Giraffe, which in turn parses it slightly differently for TableLayer to consume. Thus, there is double parsing. This is very costly for ui performance.

Proposal:
Avoid double parsing. Giraffe's config interface should allow TableLayer to optionally accept another data property to avoid double parsing.

Considerations:
Keep TableLayer backwards compatible by continuing to allow it to use fluxResponse. This is for open source users.

@TCL735 TCL735 changed the title TableLayer: update interface to avoid double parsing Visualization: TableLayer: update interface to avoid double parsing Aug 3, 2022
@TCL735
Copy link
Contributor Author

TCL735 commented Sep 30, 2022

The table-specific parser is not handling edge cases correctly. Here is an example csv where an extra "undefined" table appears. There's newlines within each row of data that is potentially causing the problem.

2022-09-30_09_35_influxdb_data.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant