Unclosed socket after calling the buckets_api

[t-schanz]

When running Unittest on the following minimal example of code, I get a Warning that not all resources are closed.

import unittest
import os

from influxdb_client import InfluxDBClient
import tracemalloc

tracemalloc.start()


class InfluxTest(unittest.TestCase):

    def setUp(self) -> None:
        self.client = InfluxDBClient(url=os.environ.get("INFLUX_URL"),
                                     token=os.environ.get("INFLUX_TOKEN"))
        self.bucket_api = self.client.buckets_api()

    def tearDown(self) -> None:
        self.client.__del__()
        del self.bucket_api

    def test_connection(self):
        self.bucket_api.find_buckets().to_dict()

When I use other APIs like the query_api, I don't get that warning. Does it have something to do with the bucket API not having a __del__() method?

This is the warning I get (I replaced my ip with xxxx):

ResourceWarning: unclosed <socket.socket fd=5, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('x.x.x.x', 50040), raddr=('x.x.x.x', 9999)>
  del self.bucket_api
Object allocated at (most recent call last):
  File "/Users/myuser/opt/anaconda3/envs/myenv/lib/python3.7/site-packages/urllib3/util/connection.py", lineno 65
    sock = socket.socket(af, socktype, proto)`

[bednar]

Hi @tmachnitzki,

I tried your code by: pytest github_test.py and everything works correctly.

My environment is: platform darwin -- Python 3.7.6, pytest-5.3.5, py-1.8.1, pluggy-0.13.1

Please, could you provide more info how to simulate it?

Regards

[t-schanz]

I use Python 3.7.6 on macOS Catalina. Unfortunately I am not able to find out the unittest version number, as it is neither listed in conda or pip, nor does the package has a __version__ string.

Using pytest I am not getting the warning either, only using unittest with
python -m unittest github_test.py.

[bednar]

The problem is caused by unclosed pool_manager:

influxdb-client-python/influxdb_client/rest.py

Line 97 in ce81899

self.pool_manager = urllib3.PoolManager(

The pool_manager should be closed at:

influxdb-client-python/influxdb_client/api_client.py

Line 80 in b0cb4ab

def __del__(self):

[bednar]

Hi @tmachnitzki,

The issue is fixed in 1.5.0 milestone.

If you would like to use a dev version then install client via:

pip install git+https://github.com/influxdata/influxdb-client-python.git@master

Regards

[t-schanz]

I can confirm that it is solved, thanks for the support 😊