Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

differentiate between client vs. server errors in InfluxDbException #375

Closed
jack-kerouac opened this issue Sep 29, 2017 · 2 comments
Closed

differentiate between client vs. server errors in InfluxDbException #375

jack-kerouac opened this issue Sep 29, 2017 · 2 comments
Labels
difficulty/medium kind/enhancement

Comments

@jack-kerouac
Copy link

When dealing with an InfluxDbException, it would be useful to know whether the HTTP error code was 4xx, indicating a problem with the client, e.g. an invalid query, or whether it was a 5xx error, indicating a problem with the server.

Currently, these cases cannot be differentiated. This is important for us, because we are using Hystrix and would only like to count 5xx failures against the metrics for the circuit breaker.
@majst01
Copy link
Collaborator

majst01 commented Sep 29, 2017

OK, this would require some refactoring of the code talking to influxdb. If you have some ideas howto differentiate, your are welcome to show this in a PR.

@dubsky
Copy link
Contributor

dubsky commented Jun 1, 2018 •
edited
Loading

This has been already done in #410. See InfluxDBException.isRetryWorth()

@dubsky dubsky closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@majst01 @fmachado @jack-kerouac @dubsky