Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimeUnit to streaming query #491

Open
japdt opened this issue Aug 16, 2018 · 2 comments
Open

Add TimeUnit to streaming query #491

japdt opened this issue Aug 16, 2018 · 2 comments

Comments

@japdt
Copy link

japdt commented Aug 16, 2018

It is currently only possible to specify timeUnit as follows:
query(final Query query, TimeUnit timeUnit)

Please could you add timeUnit to all other types of queries? In particular, I would love to see:
query(Query query, int chunkSize, TimeUnit timeUnit, Consumer<QueryResult> consumer)

Thanks!

@hakandilek
Copy link

We can combine it with #498 and introduce two additional methods:

query(Query query, TimeUnit timeUnit, int chunkSize, Consumer<QueryResult> consumer)
and
query(Query query, TimeUnit timeUnit, int chunkSize, Consumer<QueryResult> resultConsumer, Consumer<Throwable> errorConsumer)

  • TimeUnit timeUnit as 2nd parameter, to keep it consistent with the other query methods

@weiss19ja
Copy link

I made a PR #509 for this issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants