Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: notify slack when master goes red #10643

Closed
mark-rushakoff opened this issue Aug 30, 2018 · 4 comments
Closed

ci: notify slack when master goes red #10643

mark-rushakoff opened this issue Aug 30, 2018 · 4 comments
Labels

Comments

@mark-rushakoff
Copy link
Contributor

Circle 2.0 supports slack notifications but doesn't seem to offer a way to only notify when one branch (i.e. master) goes red or is fixed.

It looks like there are some solutions out there to solve this, that involve running a whole separate heroku app or perhaps involving a specific outgoing webhook.

The specific motivation here was #712 and #682 were independently green, but after #712 was merged, #682 was merged cleanly but resulted in a compile error.

There's a separate discussion ongoing about whether we should require PRs to be rebased on master before merging, but even if that happens, we could still see red builds from flaky tests, and we should still receive notifications for that.

@gianarb
Copy link
Contributor

gianarb commented Dec 20, 2018

I think we can use this plugin to have a badge in idpe readme that shows up the status of the master branch https://wiki.jenkins.io/display/JENKINS/Embeddable+Build+Status+Plugin

influxdb, telegraf has something similar already. So it should help

@mark-rushakoff mark-rushakoff transferred this issue from another repository Jan 9, 2019
@stale
Copy link

stale bot commented Jul 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 23, 2019
@stale
Copy link

stale bot commented Jul 30, 2019

This issue has been automatically closed because it has not had recent activity. Please reopen if this issue is still important to you. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Jul 30, 2019

This issue has been automatically closed because it has not had recent activity. Please reopen if this issue is still important to you. Thank you for your contributions.

@stale stale bot closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants