Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add styles to Spinner component #11545

Closed
alexpaxton opened this issue Jan 24, 2019 · 1 comment
Closed

Add styles to Spinner component #11545

alexpaxton opened this issue Jan 24, 2019 · 1 comment
Assignees
@alexpaxton @OfTheDelmer

Comments

@alexpaxton
Copy link
Contributor

alexpaxton commented Jan 24, 2019 •
edited
Loading

Would be really helpful to explain what is being loaded alongside the spinner
@OfTheDelmer OfTheDelmer self-assigned this Feb 5, 2019
@alexpaxton alexpaxton mentioned this issue Feb 5, 2019
Merged
2 tasks
@alexpaxton alexpaxton changed the title Add explainer text to page loaders Add styles to Spinner component Feb 5, 2019
@alexpaxton
Copy link
Contributor Author

While investigating this issue with @OfTheDelmer we noticed that there is a Spinner component that is used widely in the UI but does not have any styles associated. By adding styles to the component it made the UI feel much nicer and mitigates the need for text explainers.

We should audit the UI and isolate areas that have a high potential for long load times and include helper text there. In the majority of the UI simply showing a spinner seems sufficient.

@alexpaxton alexpaxton self-assigned this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexpaxton alexpaxton

@OfTheDelmer OfTheDelmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexpaxton @OfTheDelmer