Fix races in CQ execution #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
fix_cq_race
branch
5 times, most recently
from
9555750 to
e86ebb0
Compare
|
These races were flagged here: |
| @@ -3955,6 +3953,18 @@ func (s *Server) runContinuousQuery(cq *ContinuousQuery) { | |||
| cq.mu.Lock() | |||
| defer cq.mu.Unlock() | |||
|
|
|||
| // Get server CQ parameters under lock, to avoid races. | |||
| s.mu.RLock() | |||
There was a problem hiding this comment.
do we really need to lock on these? They can't ever get updated on a running process. They're set when the server object is created and never set again.
There was a problem hiding this comment.
Perhaps not. This may be rather pedantic. This was a drive-by change -- the real race is around lastRun which was being written and read from different goroutines.
There was a problem hiding this comment.
I can pull this change. I agree that these settings never change.
|
yeah, this seems sane to me, even if it only could ever fail during testing. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the CQ code such that "should run" is checked within the goroutine that the CQ will run, if it does run. This avoids the race, at the cost a very-short lived goroutine if the CQ is not run.