Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing commas in string field values #2857

Merged
merged 2 commits into from
Jun 9, 2015
Merged

Fix parsing commas in string field values #2857

merged 2 commits into from
Jun 9, 2015

Conversation

jwilder
Copy link
Contributor

@jwilder jwilder commented Jun 9, 2015

Fixes a panic on writes because the field value was not parsed correctly.

panic: unsupported value type during encode fields:

goroutine 117 [running]:
github.com/influxdb/influxdb/tsdb.(*FieldCodec).EncodeFields(0xc2081c4020, 0xc2081dc180, 0x0, 0x0, 0x0, 0x0, 0x0)
/Users/jason/go/src/github.com/influxdb/influxdb/tsdb/shard.go:573 +0x8e3

@otoolep
Copy link
Contributor

otoolep commented Jun 9, 2015

Don't forget the changelog.

@otoolep
Copy link
Contributor

otoolep commented Jun 9, 2015

+1

Fixes a panic on writes because the field value was not parse correctly.

panic: unsupported value type during encode fields: <nil>

goroutine 117 [running]:
github.com/influxdb/influxdb/tsdb.(*FieldCodec).EncodeFields(0xc2081c4020, 0xc2081dc180, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/jason/go/src/github.com/influxdb/influxdb/tsdb/shard.go:573 +0x8e3
jwilder added a commit that referenced this pull request Jun 9, 2015
Fix parsing commas in string field values
@jwilder jwilder merged commit cd3e758 into master Jun 9, 2015
@jwilder jwilder deleted the jw-commas branch June 9, 2015 21:56
@toddboom
Copy link
Contributor

toddboom commented Jun 9, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants