Allow NewQueryEngine to return an error #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some errors only appear pretty deep. A "SELECT COUNT(*)" was ending up as a panic, when instead it should have been returned as a query error to the user. This adds plumbing for returning an error from NewQueryEngine.
Reproduction: execute a "SELECT COUNT(*) FROM proc.stat.cpu" and, pre-patch, you get a panic in your terminal and nothing in your browser. With this patch, you get "ERROR: function count() doesn't work with wildcards".
This also adds early-exit logic to
yieldSeriesData
where errors were being collected but not processed. I don't know if this is correct. All of my manual tests pass, and the non-coordinator tests seem to pass.