Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Go 1.5 #3731

Closed
otoolep opened this issue Aug 19, 2015 · 7 comments
Closed

Move to Go 1.5 #3731

otoolep opened this issue Aug 19, 2015 · 7 comments
Assignees
Milestone

Comments

@otoolep
Copy link
Contributor

otoolep commented Aug 19, 2015

Go 1.5 has been released.

http://blog.golang.org/go1.5

At some point (line up with a specific release) we need to move to this version of Go. This would require:

  • ensure all code compiles with Go 1.5.
  • remove explicitly setting GOMAXPROCS, since it is now automatically set to number of cores.
  • update linker flags (commit, vesion, branch) to use new form.
  • ensure all tests pass with Go 1.5.
  • update CONTRIBUTING.md.
  • moving CircleCI testing to 1.5.
  • build scripts used to create debian and RPM packages to 1.5.
  • all developers change their tool chains.
  • message to mailing list.
@otoolep
Copy link
Contributor Author

otoolep commented Aug 19, 2015

@DanielMorsing believes moving to 1.5 for the 0.9.4 release is OK. That works for me too.

@otoolep
Copy link
Contributor Author

otoolep commented Aug 19, 2015

@dgnorton @toddboom

@otoolep otoolep added this to the 0.9.4 milestone Aug 19, 2015
@otoolep otoolep self-assigned this Aug 19, 2015
@benbjohnson
Copy link
Contributor

👍 for 1.5 in 0.9.4.

@corylanou
Copy link
Contributor

🚢 1.5 in 0.9.4!

@dgnorton
Copy link
Contributor

👍 for 1.5 in 0.9.4

@scharissis
Copy link

The new GOMAXPROCS default will be (likely) better for a lot of applications, but not necessarily. Perhaps benchmarking (as part of the test suite) should determine InfluxDB's optimal setting whilst still exposing it to end users who may choose to fine-tune their deployment?

Original proposal: https://docs.google.com/document/d/1At2Ls5_fhJQ59kDK2DFVhFu3g5mATSXqqV5QrxinasI/edit

@otoolep
Copy link
Contributor Author

otoolep commented Aug 25, 2015

Sure, I have no problem exposing GOMAXPROCS control to users, in principle. By default it will be set to the number of CPUs, which is what is does today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants