Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivative function unnecessarily requires aggregate function #4148

Closed
peekeri opened this issue Sep 17, 2015 · 4 comments
Closed

Derivative function unnecessarily requires aggregate function #4148

peekeri opened this issue Sep 17, 2015 · 4 comments

Comments

@peekeri
Copy link
Contributor

peekeri commented Sep 17, 2015

version: 0.9.4.1
rpm: https://s3.amazonaws.com/influxdb/influxdb_0.9.4.1_amd64.deb
system: amazon linux 3.14.35-28.38.amzn1.x86_64

Running query:

select derivative(count) from "jvm.gc" group by instanceId, name

works fine, while:

select derivative(count) from "jvm.gc" where time > now() - 3600s group by instanceId, name

returns error:

ERR: error parsing query: aggregate function required inside the call to derivative

I don't think the second query should require aggregate function call, because there is no grouping by time. Query just limits the amount of rows returned, but does not change the first query in any other way.

@rkuchan
Copy link
Contributor

rkuchan commented Sep 17, 2015

@jwilder

@peekeri
Copy link
Contributor Author

peekeri commented Sep 17, 2015

I made a pull request with proposed fix for this. If it seems like the right thing to do, I can also add tests for it.

@HakShak
Copy link

HakShak commented Sep 23, 2015

See grafana/grafana#2802

@beckettsean
Copy link
Contributor

closing in favor of #4187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants